diff --git a/zk/pedersen_test.go b/zk/pedersen_test.go index 0961947..19d16e4 100644 --- a/zk/pedersen_test.go +++ b/zk/pedersen_test.go @@ -153,3 +153,54 @@ func TestAMalformedOpeningIsRefused(t *testing.T) { } } } + +// TestAMeasurementOfZeroOpensItsCommitment pins the case that split the SDKs. +// +// Zero is legal wherever semantic_min_encoded is 0: a detector reporting exactly +// 0.0 produces one, and C = 0*B + r*H is an ordinary commitment to it. Two of +// the three clients got it wrong in the same way -- libsodium and noble both +// refuse a scalar multiplication whose result is the identity, which is right +// for a key exchange and wrong here, and both SDKs read the refusal as an +// invalid opening. This library accepts the zero scalar and was correct. +// +// That is the argument for a shared corpus rather than per-language tests: two +// implementations agreeing is not evidence, and the one that matched the Rust +// core was the odd one out. +func TestAMeasurementOfZeroOpensItsCommitment(t *testing.T) { + vector := loadVector(t, "provenance-private-numeric-opening-zero-value") + descriptor, value, blinding := openingFrom(t, vector) + if value != 0 { + t.Fatalf("vector is not the zero case: got %d", value) + } + ok, err := VerifyOpening(descriptor, value, blinding) + if err != nil { + t.Fatalf("verify: %v", err) + } + if !ok { + t.Fatal("a measurement of zero must open its commitment") + } +} + +// TestZeroIsNotASkeletonKey guards the shape of the fix the other SDKs needed. +func TestZeroIsNotASkeletonKey(t *testing.T) { + zero := loadVector(t, "provenance-private-numeric-opening-zero-value") + other := loadVector(t, "provenance-private-numeric-opening-valid") + zeroDescriptor, _, zeroBlinding := openingFrom(t, zero) + otherDescriptor, _, otherBlinding := openingFrom(t, other) + + for _, probe := range []struct { + name string + descriptor map[string]any + value uint64 + blinding string + }{ + {"zero against another commitment", otherDescriptor, 0, otherBlinding}, + {"non-zero against the zero commitment", zeroDescriptor, 1, zeroBlinding}, + {"zero blinding against a real commitment", zeroDescriptor, 0, strings.Repeat("00", 32)}, + } { + ok, err := VerifyOpening(probe.descriptor, probe.value, probe.blinding) + if err == nil && ok { + t.Fatalf("%s: opened a commitment it must not", probe.name) + } + } +}